Add internal tool that shows difference between two JaCoCo XML reports #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Godin I'm not sure whether this more like a tool than a educational example about our API usage. Have you considered adding this to the CLI instead? |
Member
Author
|
@marchof I thought about this option - as it is now, it fits well into examples, because
|
marchof
requested changes
Jan 8, 2019
| public InputSource resolveEntity(final String publicId, | ||
| final String systemId) { | ||
| if (publicId.startsWith("-//JACOCO//DTD Report")) { | ||
| return new InputSource(new StringReader("")); |
Member
There was a problem hiding this comment.
This is an example and should follow best practices:
- check for exact DTD version to ensure compatibility
- Supply actual DTD otherwise this will fail when we merge Do not print default zero values of attributes in XML report #813
Member
Author
Member
There was a problem hiding this comment.
Sorry, my bad: I overlooked that parseAsOptionalInt() already checks for null values.
Godin
force-pushed
the
xml_diff
branch
2 times, most recently
from
c97aecf to
dbd5f99
Compare
Godin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this little utility to check changes in filters on a real projects. And would like to add it as an example.