Reduce chance of conflict with other agents #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
approved these changes
Jun 29, 2017
Member
marchof
left a comment
marchof
left a comment
There was a problem hiding this comment.
Hopefully no other agent vendor has the same idea. We should file a patent for it 😜
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was discussed in #551 :
java/lang/UnknownErroris intended for use by Virtual Machine and in rare situations, so seems that probability that it is used by other Java agents is lower compared tojava/util/UUIDand hence we should change code to use it for communication between instrumented classes and agent. In case if even this class is used by other agents, recommendation remains the same - JaCoCo agent should be the first one specified on the command line. Page "Implementation Design" in documentation should be updated accordingly.