KotlinSafeCallOperatorFilter should not be affected by presence of pseudo instructions #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leveretka
reviewed
Sep 30, 2025
Comment on lines
35
to
37
| <li>Part of bytecode generated by the Kotlin compiler for chains of safe call | ||
| operators is filtered out during generation of report | ||
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/1956">#1956</a>).</li> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <li>Part of bytecode generated by the Kotlin compiler for chains of safe call | |
| operators is filtered out during generation of report | |
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/1956">#1956</a>).</li> | |
| <li>Part of bytecode generated by the Kotlin compiler for more cases of chained safe call | |
| operators is filtered out during generation of report | |
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/1956">#1956</a>).</li> |
Member
Author
There was a problem hiding this comment.
@leveretka nice - this way it won't be identical to the one in previous version 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked in #1818
See #921 (comment)
For https://github.com/SonarSource/sonar-kotlin/tree/2.22.0.5972
prior to this change we find 102 safe call operator chains
and after 112
ie 10 more
For http://github.com/JetBrains/kotlin/tree/v2.0.0
prior to this change 5042
and after 5175
ie 133 more