KotlinSafeCallOperatorFilter should filter "unoptimized" safe call followed by elvis #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
KotlinSafeCallOperatorFilter
branch
from
67ee009 to
c5ab85e
Compare
Godin
force-pushed
the
KotlinSafeCallOperatorFilter
branch
from
c5ab85e to
26ff2fc
Compare
leveretka
approved these changes
Oct 5, 2025
Collaborator
leveretka
left a comment
leveretka
left a comment
There was a problem hiding this comment.
Implementation seems to be correct, just a bit concerned about complexity of the if. Nothing too critical to not merge this PR fast as indeed it improves the Kotlin code coverage a lot!
|
|
||
| /** | ||
| * @return non pseudo-instruction preceding given | ||
| * @return non pseudo-instruction preceding given iff it has given opcode, |
Collaborator
There was a problem hiding this comment.
is iff necessary here? It seems to me just if + otherwise is good enough explanation.
leveretka
reviewed
Oct 5, 2025
| continue; | ||
| } | ||
| } | ||
| } else if (target.getType() != AbstractInsnNode.JUMP_INSN |
Collaborator
There was a problem hiding this comment.
Complexity of this if chain is too high. Maybe you can split the logic somehow? This will make the code more readable.
Godin
force-pushed
the
KotlinSafeCallOperatorFilter
branch
from
67530e1 to
17467da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked in #1814
See #921 (comment)
For https://github.com/SonarSource/sonar-kotlin/tree/2.22.0.5972
prior to this change we find 102 safe call operator chains
and after 114
ie 12 more
For http://github.com/JetBrains/kotlin/tree/v2.0.0
prior to this change 5042
and after 5323
ie 281 more