Improve filtering of Kotlin suspending functions with tail call optimization #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
kotlin_suspend_tail_call
branch
from
87f620c to
fa12016
Compare
Godin
force-pushed
the
kotlin_suspend_tail_call
branch
from
fa12016 to
597ff8a
Compare
leveretka
reviewed
May 13, 2025
| suspension() // assertFullyCovered() | ||
| else // assertEmpty() | ||
| noSuspension() // assertFullyCovered() | ||
| } // assertEmpty() |
Collaborator
There was a problem hiding this comment.
I was looking at the test and the implementation.
It looks like with this implementation we'll ignore the return from the function. So we won't show it as red if, for example suspension() function throws an exception. Am I right or I am missing anything here?
Nevertheless, I don't think I have a better idea how to workaround this, so this solution is still better than the current behavior(at the moment it's always red if the last suspending function call contains suspending function invocations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036
Closes #1019