Add filter for Kotlin safe call operators chains #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
kotlin_safe_call_operator_chain_filter
branch
from
79be266 to
d919a63
Compare
Godin
changed the title
Godin
force-pushed
the
kotlin_safe_call_operator_chain_filter
branch
from
2ba62bd to
dd93fe2
Compare
Godin
force-pushed
the
kotlin_safe_call_operator_chain_filter
branch
from
dd93fe2 to
99018e7
Compare
Godin
force-pushed
the
kotlin_safe_call_operator_chain_filter
branch
from
99018e7 to
14fa357
Compare
leveretka
approved these changes
Dec 15, 2024
Collaborator
leveretka
left a comment
leveretka
left a comment
There was a problem hiding this comment.
LGTM!
Discussed on-site about the case where c is actually Nullable VS its "nullability" is propagated due to nullable b. These cases are indistinguishable.
Agreed that it is better to filter this out since in the described case, when nullability is propagated, it's impossible to test.
This will be a huge improvement for many Kotlin users. Thanks!
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.