Fix range for debug symbols of method parameters #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By inserting the probe array access code at the beginning of the method we accidently moved the range of the debug symbols of the method parameters after the probe array access code. Actually the method parameters are still valid from the very beginning of the method. This offset in the method parameter's debug symbols may confuse tools like Jandex.
marchof
force-pushed
the
method-parameter-debug-symbols
branch
from
1d78b8c to
8bd84ca
Compare
|
I confirm this change fixes the issue I originally reported. Great work @marchof! |
|
I verified it by running two tests:
|
Godin
approved these changes
Nov 8, 2021
Member
|
@marchof nice fix 👍 and impressive that this was unnoticed for many years 😄 @aloubyansky thank you for reporting this and testing! ❤️ |
eformat
added a commit
to petbattle/pet-battle-api
that referenced
this pull request
Nov 15, 2021
eformat
added a commit
to rht-labs/pet-battle-api
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By inserting the probe array access code at the beginning of the method
we accidently moved the range of the debug symbols of the method
parameters after the probe array access code. Actually the method
parameters are still valid from the very beginning of the method.
This offset in the method parameter's debug symbols may confuse tools
like Jandex.