-
Notifications
You must be signed in to change notification settings - Fork 1.2k
KotlinDefaultMethodsFilter should also filter methods with parameters #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Godin
wants to merge
7
commits into
master
Choose a base branch
from
kotlin_default_methods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90cea4f to
625c508
Compare
625c508 to
a12fcec
Compare
f814bda to
a12fcec
Compare
d7e756f to
fbc5a22
Compare
ab66913 to
96cb591
Compare
ragunathjawahar
added a commit
to ragunathjawahar/timelapse
that referenced
this pull request
Feb 7, 2021
Enable again after this issue (jacoco/jacoco#1137) is fixed.
|
Can you please move this to 0.8.9 and release 0.8.8 in the meantime? I don’t use Kotlin, but I do need the |
|
Would love to have this in jacoco 0.8.8! Any updates here? |
Member
|
@alisonthemonster We're working in our spare time and completely transparently: All information and the current status of the implementation can be seen in this pull request. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #905 (comment)
Filter added by #1012 in version
0.8.6doesn't take into accountsupercall followed by code other thanreturnsupercall of method with different nameIn the following example
method
mgenerated by Kotlin compiler inCshould be filtered out.In the following example
method
minCshould not be filtered out.In the following example
method
m1inCshould not be filtered out.