Skip to content

Conversation

@Godin
Copy link
Member

@Godin Godin commented Dec 16, 2020

See #905 (comment)

Filter added by #1012 in version 0.8.6 doesn't take into account

  • methods with parameters
  • methods consisting of super call followed by code other than return
  • methods consisting of super call of method with different name

In the following example

interface I {
  fun m(p: Int) = Unit
}

class C : I {
}

method m generated by Kotlin compiler in C should be filtered out.


In the following example

interface I {
  fun m() = Unit
}

class C : I {
  override fun m() {
    super.m()
    println()
  }
}

method m in C should not be filtered out.


In the following example

interface I {
  fun m1() = Unit
  fun m2() = Unit
}

class C : I {
  override fun m1() {
    super.m2()
  }
}

method m1 in C should not be filtered out.

@Godin Godin added this to the 0.8.7 milestone Dec 16, 2020
@Godin Godin self-assigned this Dec 16, 2020
@Godin Godin marked this pull request as draft December 16, 2020 16:38
@Godin Godin force-pushed the kotlin_default_methods branch from 90cea4f to 625c508 Compare December 16, 2020 21:21
@Godin Godin force-pushed the kotlin_default_methods branch from 625c508 to a12fcec Compare December 16, 2020 21:30
@Godin Godin force-pushed the kotlin_default_methods branch from f814bda to a12fcec Compare December 16, 2020 21:44
@Godin Godin force-pushed the kotlin_default_methods branch from d7e756f to fbc5a22 Compare December 16, 2020 23:12
@Godin Godin force-pushed the kotlin_default_methods branch from ab66913 to 96cb591 Compare December 17, 2020 10:49
ragunathjawahar added a commit to ragunathjawahar/timelapse that referenced this pull request Feb 7, 2021
@Godin Godin modified the milestones: 0.8.7, 0.8.8 May 3, 2021
@mirabilos
Copy link

Can you please move this to 0.8.9 and release 0.8.8 in the meantime? I don’t use Kotlin, but I do need the assert filtering… Thanks in advance!

@alisonthemonster
Copy link

Would love to have this in jacoco 0.8.8! Any updates here?

@marchof
Copy link
Member

marchof commented Jul 9, 2021

@alisonthemonster We're working in our spare time and completely transparently: All information and the current status of the implementation can be seen in this pull request.

@Godin Godin modified the milestones: 0.8.8, 0.8.9 Apr 4, 2022
@pexa-adash

This comment was marked as off-topic.

@Godin Godin modified the milestones: 0.8.9, 0.8.10 Mar 31, 2023
@Godin Godin modified the milestones: 0.8.10, 0.8.11 Apr 24, 2023
@Godin Godin modified the milestones: 0.8.11, 0.8.12 Oct 14, 2023
@Godin Godin removed this from the 0.8.12 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Implementation
Status: In Progress

Development

Successfully merging this pull request may close these issues.

6 participants