Skip to content

Commit 2a75e0d

Browse files
authored
Remove URLStreamHandlerRuntime (#471)
* uses reflection to access internal members of the java.net.URL class * not used by default * has lower performance than ModifiedSystemClassRuntime that is used by default and than SystemPropertiesRuntime
1 parent 1485a41 commit 2a75e0d

File tree

4 files changed

+6
-191
lines changed

4 files changed

+6
-191
lines changed

org.jacoco.core.test/src/org/jacoco/core/runtime/URLStreamHandlerRuntimeTest.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

org.jacoco.core/src/org/jacoco/core/runtime/URLStreamHandlerRuntime.java

Lines changed: 0 additions & 150 deletions
This file was deleted.

org.jacoco.doc/docroot/doc/changes.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ <h3>Non-functional Changes</h3>
5757
<a href="https://github.com/jacoco/jacoco/issues/1043">#1043</a>).</li>
5858
</ul>
5959

60+
<h3>API Changes</h3>
61+
<ul>
62+
<li><code>URLStreamHandlerRuntime</code> removed
63+
(GitHub <a href="https://github.com/jacoco/jacoco/issues/471">#471</a>).</li>
64+
</ul>
65+
6066
<h2>Release 0.8.5 (2019/10/11)</h2>
6167

6268
<h3>New Features</h3>

org.jacoco.doc/docroot/doc/implementation.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,6 @@ <h2>Coverage Runtime Dependency</h2>
200200
runtime registers a custom <code>Handler</code> to receive the parameter
201201
array. This approach might break environments that install their own log
202202
managers (e.g. Glassfish).</li>
203-
<li><b><code>URLStreamHandlerRuntime</code></b>: This runtime registers a
204-
<code>URLStreamHandler</code> for a "jacoco-xxxxx" protocol. Instrumented
205-
classes open a connection on this protocol. The returned connection object
206-
is the one that provides access to the coverage runtime through its
207-
<code>equals()</code> method. However to register the protocol the runtime
208-
needs to access internal members of the <code>java.net.URL</code> class.</li>
209203
<li><b><code>ModifiedSystemClassRuntime</code></b>: This approach adds a
210204
public static field to an existing JRE class through instrumentation. Unlike
211205
the other methods above this is only possible for environments where a Java

0 commit comments

Comments
 (0)