Merged
Conversation
This reverts commit 3c6af68.
Revert "Temporarily reverting qt 6.8 upgrade for another 2.5.x release"
Removed unused variable serverHostOrPortUpdated Bumping copyright year to 2025 in various places
Updating version and docs for WIP 2.7.0-beta0
Apple Inc.: iPhone (38) Microphone
Attempting to blacklist more iPhone microphones
Enable persistent cookies, cache and local storage in WebEngine Cleanup for how WebEngine auth cookies are being set Update to Qt 6.8.3 Use static qt build when creating VST3 plugin on OSX
Reworking webengine configuration
Adding modal to select what screen or window you would like to share
VS Mode shows too many options for stereo devices
Adding some missing files to windows installer
Stop vsAudio worker thread, then destruct VsDevice, then VsAudio
Fixing order of destruction to fix seg fault when shutting down
Updated packaging to include Audio Unit for OSX, and share resources with the VST3 plugin. Both plugins now share a common AudioBridgeProcessor class that implements more of the plugin-oriented functionality. A v3 audio unit version is also included in the src/auv3 directory, but it is not currently working. It's extremely difficult to get MacOS to recognize these app extensions, and there seems to be no documentation or debugging tools available. Getting it to work is going to require a lot more trial and error hacking than I have time for right now, and there appears to be few -- if any -- real benefits to using v3. And at least according to the AIs, many hosts don't even support v3 yet.
This allows sandboxed applications to work properly on OSX, and is required for the Audio Unit version of Audio Bridge to work within tightly sandboxed host applications, such as Logic Pro Bumping version to 2.7.0-beta2 and updated changelog for release
Adding Audio Unit v2 version of the JackTrip Audio Bridge
…sion Fix sample rate conversion in Audio Unit plugin
Fix mLastSeqNumIn when packets arrive out of order
We already had some code to handle this case, but it may be different across platforms? Testing this on OSX..
Fixing lockups with some VST hosts on Windows
…onnected-message Display friendlier error message when audio interface is disconnected
Creating a static QApplication and using QThread's EventLoop with signals and slots doesn't seem to work well in the context of plugins that can be loaded and unloaded dynamically. In particular, I encountered some problems with Windows VST hosts where the first plugin you create works OK. But if you delete it and then create a second one, it locks up. It appears that there is some static flag getting set deep in QThread's EventLoop processing that basically just makes all threads exit.
Updating AudioSockets to eliminate dependency on QApplication
Requiring a skipped packets that exceeded tolerance by less than past millisecond was kind of arbitrary, and we want to start preferring quality over latency whenever auto is enabled. There is an edge case where if someone has sustained packet loss (say 1%) due to a really bad connection, it's going to keep bumping headroom until it hits max allowed. But that seems quite rare and if it is the case, they can always use the slider to adjust. Updated max headroom calculation to use 10ms greater than the last good packet used, as opposed to a fixed value of 100ms. That was also quite arbitrary. This is perhaps slightly less so? Ensure that we don't log in Regulator unless gVerbose is set (-V). Some of these happen inside the audio callback thread, which is one place you should never log outside of testing. Updated the ChangeDevices page to clean up the Auto button for the Audio quality slider a little bit. It was kind of jumpy and awkward previously. Added a RtAudioInterface::sampleRateChanged method to try and detect this, but the condition doesn't seem to be getting detected by RtAudio..
…-only Only use glitches for increasing auto headroom
If the previous call returned a predicted result (glitch), and we have a good packet available, don't process it as a glitch. Updated changelog for 2.7.0-beta2 release
Don't glitch on the first good packet if previous was a glitch
We previously would never increase auto headroom by more than 1ms for every 2 second interval. This patch allows auto headroom to increase more rapidly, when we have skipped good packets that we could have preserved. It adjusts it by enough that tolerance would have covered all of the good packets we skipped, or by at least 1ms. Don't count packet latencies during the warmup period. I'm also shortening the "warm up period" from 3+3=6 ms to 2+2=4ms, because 6ms seems a bit too long to wait before it starts making adjustments.
…droom Accelerate increases to auto headroom when we know it will help
Since this was added in Qt 6.7, older versions just break when we try to add it to a WebEngineView
Adding AUv2 component to MacOS application zip file
Conditionally include onDesktopMediaRequested based on Qt version
Fixing some issues with auto button for audio quality slider
The Meter class can be destructed before the 5 second timer expires, causing a crash due to double delete. Updated lambda bindings to be more explcit to comply with the latest c++20 standard (fixes compiler warnings). Updated version and changelog for upcoming 2.7.0 release
Fix potential double delete in volume meters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.