Fix potential double delete in volume meters#1441
Merged
mikedickey merged 1 commit intodevfrom Jun 27, 2025
Merged
Conversation
mikedickey
force-pushed
the
bugfix/meter-double-delete
branch
2 times, most recently
from
4734e84 to
84b595d
Compare
The Meter class can be destructed before the 5 second timer expires, causing a crash due to double delete. Updated lambda bindings to be more explcit to comply with the latest c++20 standard (fixes compiler warnings). Updated version and changelog for upcoming 2.7.0 release
mikedickey
force-pushed
the
bugfix/meter-double-delete
branch
from
84b595d to
f3e91f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Meter class can be destructed before the 5 second timer expires, causing a crash due to double delete.
Updated lambda bindings to be more explcit to comply with the latest c++20 standard (fixes compiler warnings).
Updated version and changelog for upcoming 2.7.0 release