Accelerate increases to auto headroom when we know it will help#1438
Merged
mikedickey merged 1 commit intodevfrom Jun 26, 2025
Merged
Accelerate increases to auto headroom when we know it will help#1438mikedickey merged 1 commit intodevfrom
mikedickey merged 1 commit intodevfrom
Conversation
We previously would never increase auto headroom by more than 1ms for every 2 second interval. This patch allows auto headroom to increase more rapidly, when we have skipped good packets that we could have preserved. It adjusts it by enough that tolerance would have covered all of the good packets we skipped, or by at least 1ms. Don't count packet latencies during the warmup period. I'm also shortening the "warm up period" from 3+3=6 ms to 2+2=4ms, because 6ms seems a bit too long to wait before it starts making adjustments.
mikedickey
force-pushed
the
bugfix/plc-accelerate-auto-headroom
branch
from
6ef912f to
7d22505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously would never increase auto headroom by more than 1ms for every 2 second interval.
This patch allows auto headroom to increase more rapidly, when we have skipped good packets that we could have preserved. It adjusts it by enough that tolerance would have covered all of the good packets we skipped, or by at least 1ms.
Don't count packet latencies during the warmup period. I'm also shortening the "warm up period" from 3+3=6 ms to 2+2=4ms, because 6ms seems a bit too long to wait before it starts making adjustments.