Only use glitches for increasing auto headroom#1436
Merged
mikedickey merged 1 commit intodevfrom Jun 26, 2025
Merged
Conversation
Requiring a skipped packets that exceeded tolerance by less than past millisecond was kind of arbitrary, and we want to start preferring quality over latency whenever auto is enabled. There is an edge case where if someone has sustained packet loss (say 1%) due to a really bad connection, it's going to keep bumping headroom until it hits max allowed. But that seems quite rare and if it is the case, they can always use the slider to adjust. Updated max headroom calculation to use 10ms greater than the last good packet used, as opposed to a fixed value of 100ms. That was also quite arbitrary. This is perhaps slightly less so? Ensure that we don't log in Regulator unless gVerbose is set (-V). Some of these happen inside the audio callback thread, which is one place you should never log outside of testing. Updated the ChangeDevices page to clean up the Auto button for the Audio quality slider a little bit. It was kind of jumpy and awkward previously. Added a RtAudioInterface::sampleRateChanged method to try and detect this, but the condition doesn't seem to be getting detected by RtAudio..
7f97556 to
fb01be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requiring a skipped packets that exceeded tolerance by less than past millisecond was kind of arbitrary, and we want to start preferring quality over latency whenever auto is enabled.
There is an edge case where if someone has sustained packet loss (say 1%) due to a really bad connection, it's going to keep bumping headroom until it hits max allowed. But that seems quite rare and if it is the case, they can always use the slider to adjust.
Updated max headroom calculation to use 10ms greater than the last good packet used, as opposed to a fixed value of 100ms. That was also quite arbitrary. This is perhaps slightly less so?
Ensure that we don't log in Regulator unless gVerbose is set (-V). Some of these happen inside the audio callback thread, which is one place you should never log outside of testing.
Updated the ChangeDevices page to clean up the Auto button for the Audio quality slider a little bit. It was kind of jumpy and awkward previously.
Added a RtAudioInterface::sampleRateChanged method to try and detect this, but the condition doesn't seem to be getting detected by RtAudio..