VS Mode improvements to audio quality override settings#1416
Merged
mikedickey merged 1 commit intodevfrom Apr 21, 2025
Merged
Conversation
Don't trigger reconnect when server host or port changes. I think it's better to trigger this via webchannel from the user interface so that the switchover happens simultaneously. Otherwise, the audio audio would reconnect right away despite having a warning and delay in the user interface. Bumping version to 2.6.0 since all this has grown to be a bit more changes than strictly "bug fixes"
mikedickey
force-pushed
the
feature/audio-quality-override-settings
branch
from
71fb7aa to
3e2e015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't trigger reconnect when server host or port changes. I think it's better to trigger this via webchannel from the user interface so that the switchover happens simultaneously. Otherwise, the audio audio would reconnect right away despite having a warning and delay in the user interface.
Bumping version to 2.6.0 since all this has grown to be a bit more changes than strictly "bug fixes"