Merge dev to main for upcoming 2.6.0 release#1407
Merged
mikedickey merged 55 commits intomainfrom Apr 21, 2025
Merged
Conversation
There was some weird back-and-forth between studioToJoin and currentStudio when someone went to device settings page before joining a studio. This leaves studioToJoin alone and defers setting currentStudio until we're switching to the connected page. Allow additional webengine flags to be set via env, for debugging
Note that this drops support for macOS versions: * 10.14 Mojave * 10.15 Catalina * 11 Big Sur The minimum required by JackTrip 2.6.0 will be macOS 12 Monterey
Don't reset studioToJoin when going to the device settings page
Fix for building with cmake and vs mode
Fix for -Dlibsamplerate=disabled
Support for changing host
meson: support libsamplerate as system dependency
Bumping builds to start using qt 6.8.2
whenever there are websocket messages received Fixing various conflicts with QML's property caching and a previous commit surrounding studioToJoin Only emit currentStudioChanged when changes are made, versus every time we receive a websocket message When there are changes to currentStudio, make sure we emit the signal before performing other actions, so that QML interface will have the latest values Trigger reconnect if there is a server port change as well, not just if there is a server host change Use QML to cache url property for web views, so that if currentStudio properties do change, it doesn't reset and kick you out Bump version to 2.6.0-beta0 to differentiate from final release Fix changelog for qt 6.8.2 update
Fixing regressions that kick you out of a studio
7zip is pre-installed on github runners
Always use 7zip on windows, since the choco zip package is flaky
This value seems quite suspect, so only printing it out for now
Adding osc endpoint to get latencies for connected clients
It turns out that our golang OSC library doesn't support arrays
…-array Send OSC response for client latencies without using an array
Renaming recv_latency to client_buffer_latency Removing some unnecessary access tokens now that we're using cookies
Adding stats for audio interface input and output
Bumping ubuntu-20.04 to ubuntu-22.04 for qmake static build, since 20.04 is no longer supported by GitHub Disabling vs mode for Linux-x64-meson-gcc-shared-nortaudio build since ubuntu-22.04 has qt 5.13 (not sure how this worked before?)
Replacing qDebug() with cout for Audio Socket reconnect
Temporarily reverting qt 6.8 upgrade for another 2.5.x release
Merge main to dev to pull in fixes
This allows us to preserve the previous state for feedback survey responses. Cleaning up feedback survey messages by splitting more things out into different fields. No need to rescan devices when reconnecting to a new server on session change.
Bumping version and updating changelog for 2.5.2 release
Don't reset device warnings and errors when stopping audio
mikedickey
requested review from
cchafe,
dhing1024 and
nwang92
and removed request for
nwang92
Fix 2.5.1 version YAML for changelog
PLC previously enforced a relatively low headroom cap, which prevented it from growing too large on poor quality Internet connections. We've found few people understand quality of service nor the implications of this. In this situation, I feel it's better to lean towards audio quality, forcing people to make adjustments to achieve low latency versus leaning towards low latency and frustrating people with audio distortion.
Allow higher latency when using PLC auto headroom
UserId is stored in settings, and may be non-empty before an authentication token is received. This can cause the studio refresh to fail, and the list to be empty.
…uthenticated Wait for authentication to finish before refreshing studios
I keep coming across crashes with backtraces pointing to `Analyzer::onTick`. Also, this feature never really worked all that well: I regularly hear complaints about it triggering when it shouldn't and I've also seen it not trigger when it should. I think it's best to just remove this until we have time to put more effort into it.
Temporarily disabling support for feedback detection in meson builds
nwang92
approved these changes
Apr 21, 2025
Don't trigger reconnect when server host or port changes. I think it's better to trigger this via webchannel from the user interface so that the switchover happens simultaneously. Otherwise, the audio audio would reconnect right away despite having a warning and delay in the user interface. Bumping version to 2.6.0 since all this has grown to be a bit more changes than strictly "bug fixes"
…-settings VS Mode improvements to audio quality override settings
mikedickey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we're ready for a new release