Fixing regressions that kick you out of a studio#1392
Merged
mikedickey merged 1 commit intodevfrom Feb 8, 2025
Merged
Conversation
whenever there are websocket messages received Fixing various conflicts with QML's property caching and a previous commit surrounding studioToJoin Only emit currentStudioChanged when changes are made, versus every time we receive a websocket message When there are changes to currentStudio, make sure we emit the signal before performing other actions, so that QML interface will have the latest values Trigger reconnect if there is a server port change as well, not just if there is a server host change Use QML to cache url property for web views, so that if currentStudio properties do change, it doesn't reset and kick you out Bump version to 2.6.0-beta0 to differentiate from final release Fix changelog for qt 6.8.2 update
mikedickey
force-pushed
the
bugfix/server-updates-kickout
branch
from
5245663 to
34d8779
Compare
nwang92
approved these changes
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing regression where you get kicked out of a studio whenever there are websocket messages received
Fixing various conflicts with QML's property caching and a previous commit surrounding studioToJoin
Only emit currentStudioChanged when changes are made, versus every time we receive a websocket message
When there are changes to currentStudio, make sure we emit the signal before performing other actions, so that QML interface will have the latest values
Trigger reconnect if there is a server port change as well, not just if there is a server host change
Use QML to cache url property for web views, so that if currentStudio properties do change, it doesn't reset and kick you out
Bump version to 2.6.0-beta0 to differentiate from final release
Fix changelog for qt 6.8.2 update