Don't reset studioToJoin when going to the device settings page#1386
Merged
mikedickey merged 1 commit intodevfrom Feb 6, 2025
Merged
Don't reset studioToJoin when going to the device settings page#1386mikedickey merged 1 commit intodevfrom
mikedickey merged 1 commit intodevfrom
Conversation
There was some weird back-and-forth between studioToJoin and currentStudio when someone went to device settings page before joining a studio. This leaves studioToJoin alone and defers setting currentStudio until we're switching to the connected page. Allow additional webengine flags to be set via env, for debugging
mikedickey
force-pushed
the
bugfix/studio-to-join
branch
from
67b7472 to
62a62a9
Compare
nwang92
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was some weird back-and-forth between studioToJoin and currentStudio when someone went to device settings page before joining a studio. This leaves studioToJoin alone and defers setting currentStudio until we're switching to the connected page.
Allow additional webengine flags to be set via env, for debugging