Fix for display of failed message screen during startup on Linux#1385
Merged
mikedickey merged 4 commits intomainfrom Jan 30, 2025
Merged
Fix for display of failed message screen during startup on Linux#1385mikedickey merged 4 commits intomainfrom
mikedickey merged 4 commits intomainfrom
Conversation
this reverts the logic in VirtualStudio::connectToStudio except that it adds an extra check for the server host being empty. The first time you connect, this should always be empty, forcing it to wait for the websocket response. But it will not be empty for subsequent reconnects to the same studio, enabling it to not have to wait for a new websocket message.
nwang92
approved these changes
Jan 30, 2025
Fix regression with reconnecting JackTrip audio during live session
Fix studio padding (or lack thereof) when browsing on Linux I think these are more related to the use of newer Qt releases versus Linux, but since we pin to older releases on other platforms I'm only mentioning that in the changelog I honestly don't understand why rearranging things in vs.qml fixes the display of the failed screen, but it seems to work.. Bump upload-artifact to v4 to fix github actions
mikedickey
force-pushed
the
bugfix/failed-screen-on-startup
branch
from
1601033 to
5c02b6c
Compare
mikedickey
force-pushed
the
bugfix/failed-screen-on-startup
branch
from
1060d83 to
150ca35
Compare
Collaborator
Author
|
It turns out that the flatpak-builder action we're using relies on an older API (v3) to upload artifacts to github, and github stopped supporting v3 today. i worked around it by telling it not to upload artifacts, and adding an extra stage using the v4 github action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix studio padding (or lack thereof) when browsing on Linux
I think these are more related to the use of newer Qt releases versus Linux, but since we pin to older releases on other platforms I'm only mentioning that in the changelog
I honestly don't understand why rearranging things in vs.qml fixes the display of the failed screen, but it seems to work..