Fix regression with reconnecting JackTrip audio during live session#1384
Merged
mikedickey merged 1 commit intodevfrom Jan 30, 2025
Merged
Fix regression with reconnecting JackTrip audio during live session#1384mikedickey merged 1 commit intodevfrom
mikedickey merged 1 commit intodevfrom
Conversation
this reverts the logic in VirtualStudio::connectToStudio except that it adds an extra check for the server host being empty. The first time you connect, this should always be empty, forcing it to wait for the websocket response. But it will not be empty for subsequent reconnects to the same studio, enabling it to not have to wait for a new websocket message.
mikedickey
force-pushed
the
bugfix/reconnect-regression
branch
from
6e64fc7 to
ce40f48
Compare
nwang92
approved these changes
Jan 30, 2025
Collaborator
Author
|
flatpak job seems flaky.. like it doesn't like the git hash or something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this reverts the logic in VirtualStudio::connectToStudio except that it adds an extra check for the server host being empty. The first time you connect, this should always be empty, forcing it to wait for the websocket response. But it will not be empty for subsequent reconnects to the same studio, enabling it to not have to wait for a new websocket message.