Merging dev to main for 2.5.0 release#1379
Merged
mikedickey merged 124 commits intomainfrom Jan 21, 2025
Merged
Conversation
…en-permission-denied Show open privacy button when microphone permission denied on mac
Fixes to cmake builds after recent changes. Also includes a fix to allow the classic interface to build with ancient versions of Qt.
Fixes for cmake builds
macos-12 runners are deprecated and will be removed December 3, 2024
Upgrade MacOS GitHub Actions runners to 13
adjust broadcast queue length so that time duration matches across all clients
Also add sha tag to container for develop branch builds base64: invalid argument --output Usage: base64 [-hDd] [-b num] [-i in_file] [-o out_file] -h, --help display this message -Dd, --decode decodes input -b, --break break encoded string into num character lines -i, --input input file (default: "-" for stdin) -o, --output output file (default: "-" for stdout)
Work-around for broken base64 on macos 13
…n-window-change Close feedback dialog on window change
…k-fields Add structured feedback fields
Updated logic for Regulator::setQueueBufferLength to handle both fixed and auto headroom. Moved queue buffer update logging up to once per change versus once per client per change. Added mAutoHeadroomStartTime to handle headroom calculation being started after initialization. No need to moc oscpp headers. It just gives warnings since there is nothing to moc.
A few updates for osc server support
Otherwise, the linker silently allows missing symbol references. That makes it very unreliable across VST hosts because the ones that have already loaded the missing symbols will work but those that have not fail to load. This makes the plugin work also in Carla. Still not working in Audacity, but then again no VST3 plugins seem to work with it, even the VST3 SDK examples! Add support for setBusArrangement() to enforce either mono -> mono or stereo -> stereo. Otherwise, the plugin appears to support 64 inputs and 64 outputs, which is incorrect.
VST plugins connected state Fixing some clag formatting issues
Bumping version to 2.5.0-beta1 and updated changelog
The call to WaitFreeFrameBuffer::pop seems to be copying more bytes than it should and somehow causing corruption. This works around it but I'm not 100% sure why.
JackTrip Audio Bridge VST3 Plugin
This makes the code a lot simpler and eliminate the need to even think about things like local and remote buffer sizes. Not having to wait for buffer size boundaries can also help minimize any latency introduced.
Improvements to vst logging so that it includes cout and cerr
Updates to make clang happy
It actually was logging out by clearing the access token, but we were failing to also clear the new refresh token. So it would just immediately trigger the cycle to use the refresh token to get a new access token, effectively logging in again right away. Clearing the refresh token on logout fixes the problem, but also best to stop the refresh timer (it will get started again after successful login). Also bumping version and changelog for beta2 release
Fix bug preventing logout from virtual studio mode
Sample rate conversion for audio sockets
I've learned that trying to use two sliders to control the mixing of two channels of audio is always a bad idea. It's always better to use a single knob or slider that adjusts the mix between the two, and if necessary a separate gain knob. Also fixing double trigger of vs token refresh at startup.
Replacing Receive and Passthrough knobs with Mix and Gain
Fix for missing cmake in dockerfile
Based on some feedback, this helps to help clarify that the two knobs on the right are for controlling the plugin's output audio
Adding Output to plugin knob labels
Jan and I went through a bunch of iterations on this, and came to the realization that there is really no need to applying extra gain to the plugin's output audio, and the extra UX complexity this third dial adds wasn't worth it. This updated design also adds some extra labels to help make it clearer where the "Send" is going, that the "Mix" applies to audio output from the plugin, and what you are mixing between.
Removing the extra Gain dial from audio bridge interface
Adding a hack so that airpods work despite behavior poorly
…nversion RtAudioInterface support for sample rate conversion
Commenting out some qDebug() statements in AudioSockets
Updating version and changelog for 2.5.0 release
nwang92
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.