Skip to content

Comments

Removing the extra Gain dial from audio bridge interface#1376

Merged
mikedickey merged 1 commit intodevfrom
feature/audio-bridge-two-dials
Jan 17, 2025
Merged

Removing the extra Gain dial from audio bridge interface#1376
mikedickey merged 1 commit intodevfrom
feature/audio-bridge-two-dials

Conversation

@mikedickey
Copy link
Collaborator

Jan and I went through a bunch of iterations on this, and came to the realization that there is really no need to applying extra gain to the plugin's output audio, and the extra UX complexity this third dial adds wasn't worth it.

This updated design also adds some extra labels to help make it clearer where the "Send" is going, that the "Mix" applies to audio output from the plugin, and what you are mixing between.

Screenshot 2025-01-17 at 1 59 31 PM

Jan and I went through a bunch of iterations on this, and came
to the realization that there is really no need to applying
extra gain to the plugin's output audio, and the extra UX
complexity this third dial adds wasn't worth it.

This updated design also adds some extra labels to help make
it clearer where the "Send" is going, that the "Mix" applies
to audio output from the plugin, and what you are mixing between.
@mikedickey mikedickey force-pushed the feature/audio-bridge-two-dials branch from 92b9b49 to 2075626 Compare January 17, 2025 22:22
@mikedickey
Copy link
Collaborator Author

mikedickey commented Jan 17, 2025

Note also that the new approach and default settings should be non-destructive, in that the signal going out of the plugin will not be altered from the signal going into it. I think this is especially important given that people will usually be using this as a plugin that they drop into their insert chain, which likely has other effects. Most use cases are for purely sending audio, and I don't think we want to alter the track's signal unless they explicitly change the output mix to do so. Conversely, this allows someone to record using an unaltered signal from JackTrip by just turning the mix dial all the way to the right. I think this is a lot better than previous approaches we tried such as "divide by two" (which always alters the signal) and "divide by sum of the two" (which has wonky behavior of changing one dial possibly -- but not always -- affecting the signal controlled by the other dial).

@mikedickey mikedickey merged commit 86cc84b into dev Jan 17, 2025
19 checks passed
@mikedickey mikedickey deleted the feature/audio-bridge-two-dials branch January 17, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants