Replacing Receive and Passthrough knobs with Mix and Gain#1372
Merged
mikedickey merged 1 commit intodevfrom Jan 16, 2025
Merged
Replacing Receive and Passthrough knobs with Mix and Gain#1372mikedickey merged 1 commit intodevfrom
mikedickey merged 1 commit intodevfrom
Conversation
I've learned that trying to use two sliders to control the mixing of two channels of audio is always a bad idea. It's always better to use a single knob or slider that adjusts the mix between the two, and if necessary a separate gain knob. Also fixing double trigger of vs token refresh at startup.
mikedickey
force-pushed
the
feature/mix-gain-knobs
branch
from
488e43b to
887c544
Compare
nwang92
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've learned that trying to use two sliders to control the mixing of two channels of audio is always a bad idea. It's better to use a single knob or slider that adjusts the mix between the two, and if necessary a separate gain knob.