Fix bug preventing logout from virtual studio mode#1371
Merged
mikedickey merged 1 commit intodevfrom Jan 16, 2025
Merged
Conversation
It actually was logging out by clearing the access token, but we were failing to also clear the new refresh token. So it would just immediately trigger the cycle to use the refresh token to get a new access token, effectively logging in again right away. Clearing the refresh token on logout fixes the problem, but also best to stop the refresh timer (it will get started again after successful login). Also bumping version and changelog for beta2 release
nwang92
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It actually was logging out by clearing the access token, but we were failing to also clear the new refresh token. So it would just immediately trigger the cycle to use the refresh token to get a new access token, effectively logging in again right away.
Clearing the refresh token on logout fixes the problem, but also best to stop the refresh timer (it will get started again after successful login).
Also bumping version and changelog for beta2 release