Skip to content

Comments

Sample rate conversion for audio sockets#1370

Merged
mikedickey merged 4 commits intodevfrom
feature/sample-rate-conversion
Jan 16, 2025
Merged

Sample rate conversion for audio sockets#1370
mikedickey merged 4 commits intodevfrom
feature/sample-rate-conversion

Conversation

@mikedickey
Copy link
Collaborator

Audio socket support for sample rate conversion

Interleave samples for audio sockets. This makes the code a lot simpler and eliminate the need to even think about things like local and remote buffer sizes. Not having to wait for buffer size boundaries can also help minimize any latency introduced.

Improvements to vst logging so that it includes cout and cerr

This makes the code a lot simpler and eliminate the need to
even think about things like local and remote buffer sizes.
Not having to wait for buffer size boundaries can also help
minimize any latency introduced.
Improvements to vst logging so that it includes cout and cerr
@mikedickey mikedickey changed the title Feature/sample rate conversion Sample rate conversion for audio sockets Jan 15, 2025
@mikedickey mikedickey force-pushed the feature/sample-rate-conversion branch 2 times, most recently from 42ca492 to ad8e8fa Compare January 15, 2025 20:12
Updates to make clang happy
@mikedickey mikedickey force-pushed the feature/sample-rate-conversion branch from ad8e8fa to fa14c71 Compare January 15, 2025 20:15
@mikedickey mikedickey marked this pull request as ready for review January 15, 2025 23:24
@mikedickey
Copy link
Collaborator Author

@ntonnaett is there some magic required to allow flatpak to download files over the Internet? It seems to be failing here. Or perhaps there is a way to use a local package of libsamplerate? I disabled sample rate conversion in Flatpak for now.

@mikedickey mikedickey merged commit a2a6c63 into dev Jan 16, 2025
18 checks passed
found_libsamplerate = false
if get_option('libsamplerate').allowed()
opt_var = cmake.subproject_options()
if get_option('buildtype') == 'release'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good choice. Distributions use debugoptimized for releases because they generate packages for debug symbols. The wording is just stupid because they copied the naming from cmake.

@ntonnaett
Copy link
Collaborator

@ntonnaett is there some magic required to allow flatpak to download files over the Internet? It seems to be failing here. Or perhaps there is a way to use a local package of libsamplerate? I disabled sample rate conversion in Flatpak for now.

I think what you want is to install the dependency first and then check for the dependency. If the dependency is not available, do the logic that is already there.

@ntonnaett
Copy link
Collaborator

It's not stable yet, but in the future the best way might be to use this for the wrap: https://mesonbuild.com/Wrap-dependency-system-manual.html#cmake-wraps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants