Skip to content

Comments

Fix for audio devices that contain a comma#1364

Merged
psiborg112 merged 8 commits intodevfrom
rtaudio-delimiter-fix
Dec 26, 2024
Merged

Fix for audio devices that contain a comma#1364
psiborg112 merged 8 commits intodevfrom
rtaudio-delimiter-fix

Conversation

@psiborg112
Copy link
Collaborator

Allow for a comma to be escaped with a backslash if it's part of an rtaudio device name. (Should fix #1363.)

Allow for a comma to be escaped with a backslash if it's part of an rtaudio device name.
@psiborg112 psiborg112 marked this pull request as draft December 23, 2024 13:20
@psiborg112 psiborg112 marked this pull request as ready for review December 23, 2024 14:09
@psiborg112
Copy link
Collaborator Author

Should have clarified that this is for specifying the device on the command line. (But the related bug makes that clear.)

@psiborg112
Copy link
Collaborator Author

Also, just realised I've only tested this on linux and have assumed that a slash inside quotations ("\") will be interpreted the same way on the command line of each platform. (Does anyone know if that holds true on the windows command line?)

@mikedickey mikedickey self-requested a review December 24, 2024 18:30
Copy link
Collaborator

@mikedickey mikedickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works ok on mac

@psiborg112 psiborg112 merged commit 0eb00ec into dev Dec 26, 2024
19 checks passed
@syneme
Copy link

syneme commented Jan 23, 2025

Thanks guys! ran rtmode from command line, but I'm still getting that error about unescaped commas: "/usr/local/bin/jacktrip -C 47.95.31.155 --rtaudio --srate 48000 --bufsize 128 --audiodevice "Rogue Amoeba Software, Inc.: Loopback1","Rogue Amoeba Software, Inc.: Loopback1" -o 0 --sendchannels 2 --receivechannels 2 -q auto -r 1 -b 16 -z --bufstrategy 3 --udprt -K "ken5"
ERROR:
Found multiple unescaped commas in the --audiodevice argument, cannot parse reliably.
Exiting JackTrip...

chatGPT'd:
In command-line tools, you can escape a comma by preceding it with a backslash ():
--audiodevice "device_name\,extra_info"

so I tried that command line with the "\" character before the comma, and it worked!

@syneme
Copy link

syneme commented Jan 23, 2025

works ok on mac

did you try Rouge Amoeba's Loopback ?

device name reads as:
"Rogue Amoeba Software, Inc.: Loopback1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants