Prefer glitch count to skipped for increasing headroom#1355
Merged
mikedickey merged 1 commit intodevfrom Dec 10, 2024
Merged
Conversation
mikedickey
force-pushed
the
feature/regulator-latency-stats
branch
from
973e590 to
e98980f
Compare
Collaborator
|
took it for a spin, seems well-behaved -- on this network it's similar to the current 'main' branch |
mikedickey
force-pushed
the
feature/regulator-latency-stats
branch
from
e98980f to
0eed982
Compare
This seems to be a better indicator which allows it grow and adjust faster for bad connections, without having an adverse impact on good connections. Adding latency stat for Regulator (use "-I 1" to see it). This is helpful because tolerance is a maximum, and not necessarily indicative of true latency. Adding receive latency to vs device heartbeat Fix bug when setting queueBuffer before connection
mikedickey
force-pushed
the
feature/regulator-latency-stats
branch
from
0eed982 to
9fe6042
Compare
nwang92
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a better indicator which allows it grow and adjust faster for bad connections, without having an adverse impact on good connections.
Adding latency stat for Regulator (use "-I 1" to see it). This is helpful because tolerance is a maximum, and not necessarily indicative of true latency.
Adding receive latency to vs device heartbeat