Refresh Access Token Automatically When Keeping App Open For Long Durations#1354
Merged
mikedickey merged 1 commit intodevfrom Dec 8, 2024
Merged
Refresh Access Token Automatically When Keeping App Open For Long Durations#1354mikedickey merged 1 commit intodevfrom
mikedickey merged 1 commit intodevfrom
Conversation
mikedickey
approved these changes
Dec 8, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should handle the cases of people leaving their app open for long durations (>24h) more robustly. Currently, we don't continuously refresh our access token (which expires after 24h) after the initial app login, so things may break if you try to use the app after it expires.
This handles a few more cases by adding a
This should additionally handle the case where the device goes to sleep for >24hours and wakes up again (though the user would need to click on the window to focus it and refresh the token). Having that done automatically might be useful but can be done in a separate PR if we need it.