A few updates for osc server support#1351
Merged
mikedickey merged 1 commit intofeature/osc-config-serverfrom Nov 27, 2024
Merged
A few updates for osc server support#1351mikedickey merged 1 commit intofeature/osc-config-serverfrom
mikedickey merged 1 commit intofeature/osc-config-serverfrom
Conversation
Updated logic for Regulator::setQueueBufferLength to handle both fixed and auto headroom. Moved queue buffer update logging up to once per change versus once per client per change. Added mAutoHeadroomStartTime to handle headroom calculation being started after initialization. No need to moc oscpp headers. It just gives warnings since there is nothing to moc.
mikedickey
force-pushed
the
feature/osc-config-mike
branch
from
ccc1a94 to
81c250a
Compare
nwang92
approved these changes
Nov 27, 2024
Contributor
nwang92
left a comment
nwang92
left a comment
There was a problem hiding this comment.
LGTM, just noting that we're currently sending values of [0, 128] to this endpoint, so we'll probably want to make some changes to use [-128, 0] when using buffer strategy 3/4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated logic for Regulator::setQueueBufferLength to handle both fixed and auto headroom.
Moved queue buffer update logging up to once per change versus once per client per change.
Added mAutoHeadroomStartTime to handle headroom calculation being started after initialization.
No need to moc oscpp headers. It just gives warnings since there is nothing to moc.