Skip to content

Comments

Adding OSC config server#1350

Merged
mikedickey merged 10 commits intodevfrom
feature/osc-config-server
Dec 7, 2024
Merged

Adding OSC config server#1350
mikedickey merged 10 commits intodevfrom
feature/osc-config-server

Conversation

@nwang92
Copy link
Contributor

@nwang92 nwang92 commented Nov 21, 2024

This PR embeds https://github.com/kaoskorobase/oscpp to establish the ability to send OSC packets to the jacktrip server process

@nwang92 nwang92 force-pushed the feature/osc-config-server branch from 9db5f04 to b9f5c26 Compare November 22, 2024 00:18
@nwang92 nwang92 force-pushed the feature/osc-config-server branch 3 times, most recently from 0f973ea to 80397c1 Compare November 22, 2024 23:52
@nwang92 nwang92 force-pushed the feature/osc-config-server branch from 80397c1 to 7eebe48 Compare November 22, 2024 23:55
@nwang92 nwang92 marked this pull request as draft November 22, 2024 23:55
@nwang92 nwang92 force-pushed the feature/osc-config-server branch from c04e01e to e137203 Compare November 24, 2024 22:06
@nwang92 nwang92 force-pushed the feature/osc-config-server branch from e137203 to 1f3b8f3 Compare November 24, 2024 22:15
@nwang92 nwang92 marked this pull request as ready for review November 25, 2024 17:09
@mikedickey
Copy link
Collaborator

I think we should move oscpp into the externals subdirectory, and have a separate #define for that (independent of virtual studio), as well as a separate meson build time option to enable it, similar to how we use the Simple-FFT project. We usually build jacktrip server with nogui (which also disables all the virtual studio mode stuff).

Updated logic for Regulator::setQueueBufferLength to handle both
fixed and auto headroom.

Moved queue buffer update logging up to once per change versus
once per client per change.

Added mAutoHeadroomStartTime to handle headroom calculation being
started after initialization.

No need to moc oscpp headers. It just gives warnings since there
is nothing to moc.
@nwang92
Copy link
Contributor Author

nwang92 commented Nov 27, 2024

I think we should move oscpp into the externals subdirectory, and have a separate #define for that (independent of virtual studio), as well as a separate meson build time option to enable it, similar to how we use the Simple-FFT project. We usually build jacktrip server with nogui (which also disables all the virtual studio mode stuff).

Can do

@nwang92 nwang92 force-pushed the feature/osc-config-server branch 2 times, most recently from da1abf9 to edabe2b Compare December 2, 2024 17:13
@nwang92 nwang92 force-pushed the feature/osc-config-server branch from edabe2b to 64af7c9 Compare December 2, 2024 18:00
@nwang92 nwang92 requested a review from mikedickey December 2, 2024 18:20
@mikedickey mikedickey merged commit bad2c65 into dev Dec 7, 2024
@mikedickey mikedickey deleted the feature/osc-config-server branch December 7, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants