Conversation
9db5f04 to
b9f5c26
Compare
0f973ea to
80397c1
Compare
80397c1 to
7eebe48
Compare
c04e01e to
e137203
Compare
e137203 to
1f3b8f3
Compare
Collaborator
|
I think we should move |
mikedickey
requested changes
Nov 27, 2024
Updated logic for Regulator::setQueueBufferLength to handle both fixed and auto headroom. Moved queue buffer update logging up to once per change versus once per client per change. Added mAutoHeadroomStartTime to handle headroom calculation being started after initialization. No need to moc oscpp headers. It just gives warnings since there is nothing to moc.
A few updates for osc server support
Contributor
Author
Can do |
da1abf9 to
edabe2b
Compare
edabe2b to
64af7c9
Compare
mikedickey
reviewed
Dec 6, 2024
mikedickey
approved these changes
Dec 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR embeds https://github.com/kaoskorobase/oscpp to establish the ability to send OSC packets to the jacktrip server process