A few proposals#1
Closed
jack-berg wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
updateConfigandsetConfigProperty— mutation belongs on the SDK implementation, not the API, analogous to howSdkTracerProvider.shutdown()doesn't appear onTracerProviderupdateConfigandsetConfigPropertyconsolidated into a singlesetConfig(String path, Object value)— the path includes the key as its final segment, so callers no longer split path from key; accepts String, Boolean, Long, Double, Integer,DeclarativeConfigProperties, or a List thereof; validates that the type of an existing value does not changeAtomicReferenceCAS loops withsynchronized(lock)covering both mutation and notification dispatch, fixing out-of-order notification delivery under concurrent writers;openTelemetryConfigModeldowngraded tovolatilesince reads remain lock-freeshutdown()andListenerRegistrationsimplified — the lock eliminates the need to iterate-and-close individual registrations on shutdown, the double-check pattern inaddConfigChangeListener, and theAtomicBoolean closedguard on registrations