Skip to content

Fix overflow in numeric scanning#2417

Merged
jackc merged 1 commit intojackc:masterfrom
ilidemi:fix-numeric-overflow
Nov 1, 2025
Merged

Fix overflow in numeric scanning#2417
jackc merged 1 commit intojackc:masterfrom
ilidemi:fix-numeric-overflow

Conversation

@ilidemi
Copy link
Copy Markdown
Contributor

@ilidemi ilidemi commented Nov 1, 2025

Fixes #2415 which was happening due to int16 overflow when multiplying -11133 by 4. Adds all tests from #2416 which would be failing on the original code.

@jackc jackc merged commit 79b1775 into jackc:master Nov 1, 2025
7 of 14 checks passed
@ilidemi
Copy link
Copy Markdown
Contributor Author

ilidemi commented Nov 1, 2025

@jackc thanks for a quick merge! No rush, but curious if there's a rough timeline for the next release?

@jackc
Copy link
Copy Markdown
Owner

jackc commented Nov 1, 2025

Some time this month would be my guess.

ilidemi added a commit to PeerDB-io/peerdb that referenced this pull request Jan 7, 2026
clickhouse-go has ClickHouse/clickhouse-go#1741
to help with classification
pgx has jackc/pgx#2417 to avoid getting stuck on
large numerics
prost is not yet, one buf plugin version away
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgtype: NUMERIC binary decode hangs/infinite loop for large-weight values (misuses dscale)

2 participants