Skip to content

pgtype numeric remove dscale#2416

Closed
serprex wants to merge 4 commits intojackc:masterfrom
serprex:numeric-remove-dscale
Closed

pgtype numeric remove dscale#2416
serprex wants to merge 4 commits intojackc:masterfrom
serprex:numeric-remove-dscale

Conversation

@serprex
Copy link
Copy Markdown
Contributor

@serprex serprex commented Oct 30, 2025

fixes #2415

@serprex serprex force-pushed the numeric-remove-dscale branch from 5669a1f to 4ae9a59 Compare October 30, 2025 01:58
@ilidemi
Copy link
Copy Markdown
Contributor

ilidemi commented Oct 31, 2025 

--- FAIL: TestNumericCodec (1.61s)
    /Users/ilia/Code/pgx/pgtype/numeric_test.go:82: 35. cache statement: unexpected result for 1.23: 1.2300
    /Users/ilia/Code/pgx/pgtype/numeric_test.go:82: 35. cache describe: unexpected result for 1.23: 1.2300
    /Users/ilia/Code/pgx/pgtype/numeric_test.go:82: 35. describe exec: unexpected result for 1.23: 1.2300

@ilidemi ilidemi mentioned this pull request Nov 1, 2025
Merged
@serprex serprex closed this Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pgtype: NUMERIC binary decode hangs/infinite loop for large-weight values (misuses dscale)

2 participants

@serprex @ilidemi