Add FLAC Support for Audio Uploads#91
Closed
Zidiam wants to merge 2 commits intojackTabsCode:mainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
Flacvariant to theAudioKindenum in Asphalt's asset handling, enabling.flacaudio files to be properly recognized and mapped toCloudAssetType::AudioFlac. The primary changes include:AudioKindenum to supportFlac..flacin theAsset::newconstructor, so Asphalt no longer errors on unknown extension.AudioKind::FlactoCloudAssetType::AudioFlac, allowing the upload process to treat.flaclike any other supported audio format.With this addition,
.flacfiles can now be uploaded as high-fidelity audio assets through Asphalt without manual format conversion or “unknown extension” errors.Don't Merge Untill rbxcloud merges in:
Sleitnick/rbxcloud#65