This repository was archived by the owner on Nov 2, 2026. It is now read-only.
Repository navigation
Honor MUNUS_DB_PATH when opening SQLite database - #24
Merged
jabbott-iii merged 1 commit intoAug 8, 2026
Merged
Conversation
jabbott-iii
approved these changes
Aug 8, 2026
jabbott-iii
marked this pull request as ready for review
August 8, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MUNUS_DB_PATHwhen configuredmunus.dbas the default for local useWhy
The Docker image sets
MUNUS_DB_PATH=/app/data/munus.db, but the application previously passed the literalmunus.dbtoNewDatabase. As a result, container data was written outside the documented persistent volume.Validation
go test -v database_path.go database_path_test.gogo test -count=100 database_path.go database_path_test.gogo vet database_path.go database_path_test.gogo mod tidy(no module diff)gofmtandgit diff --checkThe repository-wide suite is currently blocked by pre-existing compilation errors in the unfinished export/import code on
main; this PR does not modify those files.Fixes #23