Revert "add support for diagnostic feedback"

lukaseder · lukaseder · commit 528496fde455 · 2022-03-31T09:04:24.000+02:00
This reverts commit 34580bb.
diff --git a/jOOR-java-8/pom.xml b/jOOR-java-8/pom.xml
@@ -11,7 +11,7 @@
 
     <groupId>org.jooq</groupId>
     <artifactId>joor-java-8</artifactId>
-    <version>0.9.14.2</version>
+    <version>0.9.14</version>
     <packaging>bundle</packaging>
 
     <name>jOOR</name>
diff --git a/jOOR-java-8/src/main/java/org/joor/Compile.java b/jOOR-java-8/src/main/java/org/joor/Compile.java
@@ -95,15 +95,15 @@ static Class<?> compile(String className, String content, CompileOptions compile
                     options.addAll(Arrays.asList("-classpath", classpath.toString()));
                 }
 
-                CompilationTask task = compiler.getTask(out, fileManager, compileOptions.diagnosticListener, options, null, files);
+                CompilationTask task = compiler.getTask(out, fileManager, null, options, null, files);
 
                 if (!compileOptions.processors.isEmpty())
                     task.setProcessors(compileOptions.processors);
 
                 task.call();
 
                 if (fileManager.isEmpty()) {
-                    if (compileOptions.hasOption("-proc:only")) {
+                    if (compileOptions.hashOption("-proc:only")) {
                         return null;
                     }
                     throw new ReflectException("Compilation error: " + out);
diff --git a/jOOR-java-8/src/main/java/org/joor/CompileOptions.java b/jOOR-java-8/src/main/java/org/joor/CompileOptions.java
@@ -21,8 +21,6 @@
 import java.util.List;
 
 import javax.annotation.processing.Processor;
-import javax.tools.DiagnosticListener;
-import javax.tools.JavaFileObject;
 
 /**
  * @author Lukas Eder
@@ -31,7 +29,6 @@ public final class CompileOptions {
 
     final List<? extends Processor> processors;
     final List<String> options;
-    DiagnosticListener<JavaFileObject> diagnosticListener;
 
     public CompileOptions() {
         this(
@@ -64,19 +61,13 @@ public final CompileOptions options(List<String> newOptions) {
         return new CompileOptions(processors, newOptions);
     }
 
-    public boolean hasOption(String opt) {
+    public boolean hashOption(String opt) {
         for (String option : options) {
             if (option.equalsIgnoreCase(opt)) {
                 return true;
             }
         }
         return false;
     }
-
-    public CompileOptions withDiagnosticListener(DiagnosticListener<JavaFileObject> listener) {
-        this.diagnosticListener = listener;
-        return this;
-    }
-
 }
 
diff --git a/jOOR-java-8/src/test/java/org/joor/test/CompileOptionsTest.java b/jOOR-java-8/src/test/java/org/joor/test/CompileOptionsTest.java
@@ -15,9 +15,8 @@
 
 import java.util.Collections;
 
-import java.util.Locale;
+
 import java.util.Set;
-import java.util.concurrent.atomic.AtomicReference;
 
 import javax.annotation.processing.Completion;
 import javax.annotation.processing.ProcessingEnvironment;
@@ -28,7 +27,6 @@
 import javax.lang.model.element.Element;
 import javax.lang.model.element.ExecutableElement;
 import javax.lang.model.element.TypeElement;
-import javax.tools.Diagnostic;
 
 import org.joor.CompileOptions;
 import org.joor.Reflect;
@@ -156,7 +154,6 @@ public SourceVersion getSupportedSourceVersion() {
 
         @Override
         public void init(ProcessingEnvironment processingEnv) {
-            processingEnv.getMessager().printMessage(Diagnostic.Kind.NOTE, "running " + getClass().getName());
         }
 
         @Override
@@ -182,16 +179,10 @@ public Iterable<? extends Completion> getCompletions(Element element, Annotation
      * see https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javac.html
      */
     @Test
-    public void testProcOnlyWithDiagnostics() {
-        AtomicReference<String> diagMessage = new AtomicReference<>();
+    public void testProcOnly() {
         Object result = Reflect.compile("p.D", "package p; public class D extends B {} class B {}",
-                                        new CompileOptions().options("-proc:only")
-                                                .processors(new AProcessor())
-                                                .withDiagnosticListener(diagnostic -> {
-                                                    diagMessage.set(diagnostic.getMessage(Locale.ENGLISH));
-                                                }));
+                                        new CompileOptions().options("-proc:only").processors(new AProcessor()));
         assertNull(result);
-        assertNotNull(diagMessage.get());
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -95,15 +95,15 @@ static Class<?> compile(String className, String content, CompileOptions compile`
`95`	`95`	`options.addAll(Arrays.asList("-classpath", classpath.toString()));`
`96`	`96`	`}`
`97`	`97`
`98`		`- CompilationTask task = compiler.getTask(out, fileManager, compileOptions.diagnosticListener, options, null, files);`
	`98`	`+ CompilationTask task = compiler.getTask(out, fileManager, null, options, null, files);`
`99`	`99`
`100`	`100`	`if (!compileOptions.processors.isEmpty())`
`101`	`101`	`task.setProcessors(compileOptions.processors);`
`102`	`102`
`103`	`103`	`task.call();`
`104`	`104`
`105`	`105`	`if (fileManager.isEmpty()) {`
`106`		`- if (compileOptions.hasOption("-proc:only")) {`
	`106`	`+ if (compileOptions.hashOption("-proc:only")) {`
`107`	`107`	`return null;`
`108`	`108`	`}`
`109`	`109`	`throw new ReflectException("Compilation error: " + out);`