fix for issue #740 - #906
Merged
Merged
Conversation
joliver82
pushed a commit
to joliver82/jmonkeyengine
that referenced
this pull request
Nov 14, 2018
stephengold
added a commit
that referenced
this pull request
Dec 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the semantics of KinematicRagdollControl, particularly for addBoneName(). During and after scanSpatial(), instead of treating an empty bone list as a special case, the bone list now contains precisely the bones that are linked to physics objects. This enables the fix, as follows:
If the bone list is empty at the time the control is added to a spatial, all bones are added to the list. Before invoking scanSpatial(), however, any listed bones without vertices are filtered out. This prevents generation of empty hull shapes, saving native Bullet from choking when it tries to step the simulation.