Skip to content

Fix iOS and graalvm build - #2844

Merged
riccardobl merged 3 commits into
jMonkeyEngine:masterfrom
riccardobl:iosfix2
Jun 5, 2026
Merged

Fix iOS and graalvm build#2844
riccardobl merged 3 commits into
jMonkeyEngine:masterfrom
riccardobl:iosfix2

Conversation

@riccardobl

@riccardobl riccardobl commented Jun 5, 2026

Copy link
Copy Markdown
Member

This PR applies the following fixes to the graalvm and iOS build:

  • the native image plugin is now published in maven central
  • graalvm metadata are automatically built for ios launchers
  • the native image plugin can be used in java 21

@riccardobl riccardobl added this to the v3.10.0 milestone Jun 5, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 5, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's build configuration by adding new Maven publication tasks, downgrading the Java toolchain to version 21 and GraalVM dependencies to 23.1.3, and including 'com.jme3.app.IosApplicationLauncher' in the default target types for native image metadata. I have no feedback to provide as there were no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

✅ If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

✨ If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

@riccardobl
riccardobl merged commit dbf88e4 into jMonkeyEngine:master Jun 5, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

1 participant

@riccardobl