Skip to content

Enable Javadoc doclint errors - #2831

Merged
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
8Keep:javadoc-doclint-ci
May 28, 2026
Merged

Enable Javadoc doclint errors#2831
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
8Keep:javadoc-doclint-ci

Conversation

@8Keep

@8Keep 8Keep commented May 28, 2026

Copy link
Copy Markdown
Contributor
  • recreate the Javadoc doclint cleanup from Enable Javadoc doclint errors #2799 after revert Revert "Enable Javadoc doclint errors" #2826
  • gate strict Javadoc failures behind -PenableJavadocError=true so normal build/createZipDistribution/mergedJavadoc doesn't fail
  • add a non-blocking CI doclint job that emits a GitHub notice when strict doclint fails
  • fix the AppSettings empty <p> warning that was a land race with another pr

@8Keep
8Keep marked this pull request as ready for review May 28, 2026 20:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up Javadoc syntax, formatting, and configuration across the codebase, and introduces a conditional check (enableJavadocError) to fail on Javadoc errors. Feedback suggests a more robust way to configure the Javadoc options when errors are disabled, specifically by splitting the fragile addStringOption('Xdoclint:none', '-quiet') call into separate boolean options.

Comment thread build.gradle
Comment thread common.gradle
@riccardobl

Copy link
Copy Markdown
Member

Thank you!

@riccardobl
riccardobl merged commit 62ea013 into jMonkeyEngine:master May 28, 2026
11 checks passed
Copilot AI pushed a commit that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants