Fix shader issues - #2828
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several GLSL shaders to prevent implicit type conversion errors by explicitly casting integers to floats, and initializes newly added fields in the Light and PBRSurface structures. The review feedback highlights a few remaining implicit conversion issues in Downsample.frag (lines 27 and 29), suggests simplifying a redundant ternary operation in the calculation of surface.NdotV, recommends comparing the integer layer directly with integer literals instead of casting it to a float, and points out a duplicate assignment of surface.alpha.
Copilot AI
pushed a commit
that referenced
this pull request
Jul 15, 2026
* Fix GLSL int/float type mismatches in shaders * fix uninitialized variables * add defensive initialization * Fix floating-point in Downsample shader texture sampling * more fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues found by testing the shaders under angle GLES3