Default EnvironmentProbe SH baking to FAST and remove AUTO mode - #2817
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix QUALITY env baker support on macOS with ANGLE
Default EnvironmentProbe SH baking to FAST and remove AUTO mode
May 26, 2026
riccardobl
reviewed
May 27, 2026
riccardobl
marked this pull request as ready for review
May 27, 2026 09:16
Copilot AI
added a commit
that referenced
this pull request
Jul 15, 2026
* Initial plan * Default env baker SH mode to FAST and remove AUTO path Agent-Logs-Url: https://github.com/jMonkeyEngine/jmonkeyengine/sessions/e70ed475-af44-4c2b-9f29-f76d9a0422b8 Co-authored-by: riccardobl <[email protected]> * Harden SH mode deserialization compatibility handling Agent-Logs-Url: https://github.com/jMonkeyEngine/jmonkeyengine/sessions/e70ed475-af44-4c2b-9f29-f76d9a0422b8 Co-authored-by: riccardobl <[email protected]> * Simplify legacy SH mode mapping fallback Agent-Logs-Url: https://github.com/jMonkeyEngine/jmonkeyengine/sessions/e70ed475-af44-4c2b-9f29-f76d9a0422b8 Co-authored-by: riccardobl <[email protected]> * Avoid NPE catch in SH mode fallback parsing Agent-Logs-Url: https://github.com/jMonkeyEngine/jmonkeyengine/sessions/e70ed475-af44-4c2b-9f29-f76d9a0422b8 Co-authored-by: riccardobl <[email protected]> * Remove EnvironmentProbeControlTest per PR feedback --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: riccardobl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUALITY SH baking is unstable on macOS when using ANGLE/Metal, and AUTO could still route into problematic behavior depending on platform logic. This update removes AUTO entirely and makes FAST the default SH baking path.
Mode model simplification (AUTO removed)
SphericalHarmonicsMode.AUTOfromIBLGLEnvBakerLight.FASTandQUALITYbehavior unchanged.Default behavior change to FAST
IBLGLEnvBakerLightdefault SH mode toFAST.EnvironmentProbeControldefault SH mode toFAST.EnvironmentProbeControl.write(...)toFAST.Backward compatibility for serialized data
EnvironmentProbeControl.read(...)so legacy serialized mode values (including"AUTO") resolve toFASTinstead of failing or requiring AUTO to exist.