Skip to content

Fix KHRToneMap vec3 typo - #2815

Merged
riccardobl merged 1 commit into
masterfrom
riccardobl-patch-3
May 27, 2026
Merged

Fix KHRToneMap vec3 typo#2815
riccardobl merged 1 commit into
masterfrom
riccardobl-patch-3

Conversation

@riccardobl

@riccardobl riccardobl commented May 26, 2026

Copy link
Copy Markdown
Member

No description provided.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 26, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a type mismatch in the KHRToneMap fragment shader where a vec4 expression was incorrectly assigned to a vec3 variable (ldrColor). It has been corrected to use vec4. There are no review comments to address.

@riccardobl
riccardobl merged commit ed0b493 into master May 27, 2026
11 checks passed
@riccardobl
riccardobl deleted the riccardobl-patch-3 branch May 28, 2026 21:52
Copilot AI pushed a commit that referenced this pull request Jul 15, 2026
@riccardobl
Fix KHRToneMap vec3 typo (#2815)
a433a99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@riccardobl