Remove Java applet support - #2800
Merged
riccardobl merged 1 commit intoMay 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes Java applet support by deleting the AppletHarness, AppHarness, and TestApplet classes, and cleaning up related comments in TestSceneWater.java. Feedback suggests that since applet support is being removed, the useHttp field in TestSceneWater should no longer be static to avoid potential state leakage between test runs.
8Keep
marked this pull request as ready for review
May 23, 2026 19:17
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applets are dead since java 9, forcing us to use javadoc level 8. I ran into this when trying to fix up all javadoc lints/warnings/errors. Splitting this out into a separate PR for simplicity.