Use an offbuffer for the CI screenshot tests - #2751
Merged
riccardobl merged 10 commits intoMay 9, 2026
Merged
Conversation
…a issues in screenshots
…ility in the pipelines
richardTingle
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the screenshot testing framework by replacing ScreenshotNoInputAppState with OffScreenshotAppState, which captures screenshots from a FrameBuffer. It introduces ScenarioScreenshotRecorder to manage screenshot paths and updates the comparison logic to allow for negligible pixel differences. Review feedback identifies a logic error in the scenario comparison loop, a resource leak due to an unclosed FileOutputStream, and performance inefficiencies in the pixel-by-pixel comparison method.
…ottests/testframework/TestDriver.java Correct to actually compare the scenario with the prime Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses a separate (manually created) frame buffer rather than the screen itself. This is to help android (and possibly Vulcan) continue to work with the CI screenshot tests.
This also changes to an explicitly named screenshot filename avoiding the "figuring out which screenshot is which" that was previously required