ArmatureDebugAppState: minor fix and improvements - #2531
Merged
yaRnMcDonuts merged 2 commits intoAug 17, 2025
Conversation
codex128
reviewed
Aug 7, 2025
| } | ||
|
|
||
| private void registerInput() { | ||
| inputManager.addMapping(PICK_JOINT, new MouseButtonTrigger(MouseInput.BUTTON_LEFT), new MouseButtonTrigger(MouseInput.BUTTON_RIGHT)); |
Contributor
There was a problem hiding this comment.
Why was the right mouse button trigger removed?
Contributor
Author
There was a problem hiding this comment.
Assigning the left and right mouse buttons to the same function is redundant and not very useful. This way, the right mouse button (RMB) can be assigned to another action without interfering with this debug class.
codex128
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following improvements to the
ArmatureDebugAppStateclass:INFOlevel instead of printing toSystem.err, and formats the output as a single multi-line string for improved readability.These changes improve usability, maintainability, and adhere to best practices for logging and input management.