Wayland fullscreen issue fixed - #2492
Merged
Merged
Conversation
Member
|
Thanks for fixing this! Everything looks good to me, so I'll merge this soon. It also looks like something may have bugged out with the checks (3 different PRS that were submitted on the same day all failed, so I assume it was a glitch on GitHub's end), but you should be able to just re-run the checks for this PR and it should pass the checks this time. |
Contributor
Author
You're right! Now this PR passed the tests without any problems... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2472, which relates to fullscreen on Wayland. Interestingly, the custom bar isn't automatically disabled when launching glwf in fullscreen during a Wayland session.