Skip to content

#2442 Automate test TestInstanceNodeWithPbr - #2443

Merged
yaRnMcDonuts merged 2 commits into
jMonkeyEngine:masterfrom
richardTingle:#2442-automate-TestInstanceNodeWithPbr
May 18, 2025
Merged

#2442 Automate test TestInstanceNodeWithPbr#2443
yaRnMcDonuts merged 2 commits into
jMonkeyEngine:masterfrom
richardTingle:#2442-automate-TestInstanceNodeWithPbr

Conversation

@richardTingle

@richardTingle richardTingle commented May 16, 2025

Copy link
Copy Markdown
Member

This automates the example TestInstanceNodeWithPbr that was introduced in #2437

closes #2442

@github-actions

Copy link
Copy Markdown

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

@yaRnMcDonuts
yaRnMcDonuts merged commit 069d4e7 into jMonkeyEngine:master May 18, 2025
@yaRnMcDonuts

yaRnMcDonuts commented May 18, 2025

Copy link
Copy Markdown
Member

Strange, this PR said that it had passed all checks.

However after I merged it, I got a notification saying that the master branch build failed: https://github.com/jMonkeyEngine/jmonkeyengine/actions/runs/15092754471/job/42423482622#step:5:113

It looks like that log says:

`FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jme3-android-native:downloadStbImage'.
> Can't get https://raw.githubusercontent.com/jMonkeyEngine/stb/0224a44a10564a214595797b4c88323f79a5f934/stb_image.h to /__w/jmonkeyengine/jmonkeyengine/jme3-android-native/build/decode/stb_image.h

@stephengold @riccardobl do either of you know what this build failure indicates?

@stephengold

Copy link
Copy Markdown
Member

It has to do with building natives for Android.

Likely it's a transient network issue, in which case the job might succeed if you retry it.

@richardTingle
richardTingle deleted the #2442-automate-TestInstanceNodeWithPbr branch May 18, 2025 22:21
@yaRnMcDonuts

Copy link
Copy Markdown
Member

the job might succeed if you retry it.

Thanks, I re-ran the build and that resolved everything.

@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate TestInstanceNodeWithPbr

3 participants