Skip to content

jme3-examples: TestPostWater code cleanup - #2418

Merged
yaRnMcDonuts merged 3 commits into
jMonkeyEngine:masterfrom
capdevon:capdevon-TestPostWater
May 8, 2025
Merged

jme3-examples: TestPostWater code cleanup#2418
yaRnMcDonuts merged 3 commits into
jMonkeyEngine:masterfrom
capdevon:capdevon-TestPostWater

Conversation

@capdevon

@capdevon capdevon commented May 3, 2025

Copy link
Copy Markdown
Contributor

Refactored the TestPostWater example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.

Refactored the TestPostWater example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.

@codex128 codex128 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me. There are just a couple things I would change, but that is up to you.

Comment thread jme3-examples/src/main/java/jme3test/water/TestPostWater.java
Comment thread jme3-examples/src/main/java/jme3test/water/TestPostWater.java
Comment thread jme3-examples/src/main/java/jme3test/water/TestPostWater.java Outdated
@capdevon capdevon changed the title TestPostWater: code cleanup jme3-examples: TestPostWater code cleanup May 3, 2025
@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone May 6, 2025
@yaRnMcDonuts
yaRnMcDonuts merged commit 2fa2101 into jMonkeyEngine:master May 8, 2025
@capdevon
capdevon deleted the capdevon-TestPostWater branch June 15, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants