Skip to content

Cross-platform fix for issue 1745 (mouse input scaling) - #1753

Merged
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
riccardobl:fix1745
Jan 18, 2022
Merged

Cross-platform fix for issue 1745 (mouse input scaling)#1753
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
riccardobl:fix1745

Conversation

@riccardobl

Copy link
Copy Markdown
Member

Fix issue #1745

@bob0bob

bob0bob commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

This fix works for me after getting rid of the "saved" settings, because JME already set it to "true" by default and re-running brought them back, but when I erased the settings, it worked great.

@stephengold stephengold added this to the v3.5.0 milestone Jan 18, 2022
@stephengold

Copy link
Copy Markdown
Member

I tested this on Windows 11 with display scaling set to 150%, and it worked.

Question: do the GlfwMouseInputVR and LwjglWindowVR classes in jme-vr need similar modifications?

@stephengold stephengold changed the title Cross-platform fix Scaling issue #1745 Cross-platform fix for issue 1745 (mouse input scaling) Jan 18, 2022
@riccardobl

Copy link
Copy Markdown
Member Author

It's better to address that in a future PR, because the VR implementation doesn't seem to have any code regarding scaling and high DPI.

@stephengold

Copy link
Copy Markdown
Member

In that case, I believe this PR is ready to be integrated into "master".

@riccardobl
riccardobl merged commit 71269bb into jMonkeyEngine:master Jan 18, 2022
@stephengold

Copy link
Copy Markdown
Member

Thank you, Riccardo!

stephengold pushed a commit that referenced this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants