Conversation
|
This PR has been open 10 weeks, and no one has commented until now. I don't understand all the changes, but I built the code and ran it without difficulty on my Linux desktop. Unless there's substantial discussion, I will integrate this PR soon. |
There was a problem hiding this comment.
In general it looks good, I'd just like to know the reasoning behind the executor and potentially we can re-think the way we handle tests/examples anyway.
Technically this should find all tagged Examples rather than searching some jars for some .class files with a main method and having Test in the name :D
But that's something for a follow up I guess, this is certainly better than the one before.
Edit: you even said Uses thread pool for launching the apps instead of always spawning a new thread.
What is your worry there? the overhead of creating a thread? because those are heavy and slow examples anyway, not unit tests.
A thread pool may be useless when only one thread is used at once all the time and also properly removing the thread may reduce side effects, hypothetically
|
@MeFisto94 please continue the conversations you started or else mark them as "resolved". |
Heh, ok, this is pure cleanup type of thing and adds a bunch of... nothing. Maybe not everybody on board with this....
For all good and bad, the TestChooser should function as always with this exception: