Skip to content

Test chooser#1591

Merged
stephengold merged 6 commits intojMonkeyEngine:masterfrom
tonihele:testChooser
Nov 10, 2021
Merged

Test chooser#1591
stephengold merged 6 commits intojMonkeyEngine:masterfrom
tonihele:testChooser

Conversation

@tonihele
Copy link
Contributor

Heh, ok, this is pure cleanup type of thing and adds a bunch of... nothing. Maybe not everybody on board with this....

  • Uses NIO, should be a bit more lightweight and unifies the JAR handling (although it is still an exception of sorts)
  • Removes the complexity of using contains on an unsorted list in a loop
  • Removes the use of Vector collection type (obsolete)
  • Adds the use of generics
  • Uses thread pool for launching the apps instead of always spawning a new thread

For all good and bad, the TestChooser should function as always with this exception:

  • It shows up on OS taskbar (I at least easily lose the window)
  • It has minimize/maximize window button

@stephengold
Copy link
Member

This PR has been open 10 weeks, and no one has commented until now. I don't understand all the changes, but I built the code and ran it without difficulty on my Linux desktop. Unless there's substantial discussion, I will integrate this PR soon.

@stephengold stephengold added this to the Future Release milestone Oct 13, 2021
@MeFisto94 MeFisto94 self-requested a review October 13, 2021 22:25
Copy link
Member

@MeFisto94 MeFisto94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good, I'd just like to know the reasoning behind the executor and potentially we can re-think the way we handle tests/examples anyway.

Technically this should find all tagged Examples rather than searching some jars for some .class files with a main method and having Test in the name :D
But that's something for a follow up I guess, this is certainly better than the one before.

Edit: you even said Uses thread pool for launching the apps instead of always spawning a new thread.
What is your worry there? the overhead of creating a thread? because those are heavy and slow examples anyway, not unit tests.
A thread pool may be useless when only one thread is used at once all the time and also properly removing the thread may reduce side effects, hypothetically

@stephengold
Copy link
Member

stephengold commented Oct 24, 2021

@MeFisto94 please continue the conversations you started or else mark them as "resolved".

@stephengold stephengold modified the milestones: Future Release, v3.5.0 Oct 24, 2021
@stephengold stephengold merged commit 8acc565 into jMonkeyEngine:master Nov 10, 2021
@stephengold stephengold added the examples specific to the jme3-examples sub-project label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples specific to the jme3-examples sub-project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants