Added Override annotations, finals, some cleanup and better null checks - #1271
Conversation
|
Why did you rename the loggers? |
|
I can change them back if you like. JME uses both, actually more the lowercase one. But the uppercase one is correct. https://www.oracle.com/technetwork/articles/javaee/codeconventions-135099.html. I don't exactly know do you follow the standards on this. But since I saw both, I thought that it would be ok. |
|
A logger is not a constant. Please change the name back to the lowercase form. |
|
I'll change them back when I get home. You are right that it is not a constant. But I still think that it should be uppercase (in general, of course it should follow project's naming conventions). I'll also try to investigate can I add suppression to IDE warning to the project so that others wouldn't be so compelled to change those to upper case. This being Gradle project... but there seems to be now already some Netbeans specific configurations. |
|
LOGGER = ugly code and extra typing |
|
There you go fine sirs. At least for Netbeans there didn't seem to be any project specific muting of the warnings. |
|
Thank you for your contribution to JMonkeyEngine. My copy of the SDK (which based on NetBeans) is configured to ignore constant naming conventions, both in the editor hints and in the inspector. I'm not 100% certain how I configured the editor. Probably it was a matter of clicking on the yellow lightbulb and selecting "disable hint" in the popup menu. If you have a custom inspector configuration, disable the "Constant naming conventions" checkbox under the "Naming" category of NetBeans Java Hints. |
One file was reformatted completely, sorry about that. It was so weirdly indented. Better to ignore white spaces.
Added Override annotations, finals, some cleanup and better null checks (getCurrentScreen in couple of files caused a warning).